Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_iam_virtual_mfa_device: Correctly sweep associated devices and add enable_date and user_name attributes #32462

Merged
merged 6 commits into from
Jul 12, 2023
Merged

resource/aws_iam_virtual_mfa_device: Correctly sweep associated devices and add enable_date and user_name attributes #32462

merged 6 commits into from
Jul 12, 2023

Conversation

gdavison
Copy link
Contributor

Description

Attempting to sweep an aws_iam_virtual_mfa_device that is associated with an IAM User fails with the error

deleting IAM Virtual MFA Device (arn:aws:iam::123456789012:mfa/example): DeleteConflict: MFA VirtualDevice in use. Must deactivate first

Adds user_name attribute needed for MFA deactivation and enable_date.

Also fixes panic in OpsWorks user sweeper.

Output from Acceptance Testing

$ make testacc PKG=iam TESTS=TestAccIAMVirtualMFADevice_

--- PASS: TestAccIAMVirtualMFADevice_disappears (18.19s)
--- PASS: TestAccIAMVirtualMFADevice_basic (23.26s)
--- PASS: TestAccIAMVirtualMFADevice_path (23.32s)
--- PASS: TestAccIAMVirtualMFADevice_tags (46.32s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. sweeper Pertains to changes to or issues with the sweeper. labels Jul 11, 2023
jar-b
jar-b approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

$ make testacc PKG=iam TESTS=TestAccIAMVirtualMFADevice_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMVirtualMFADevice_'  -timeout 180m

--- PASS: TestAccIAMVirtualMFADevice_disappears (16.68s)
--- PASS: TestAccIAMVirtualMFADevice_basic (21.73s)
--- PASS: TestAccIAMVirtualMFADevice_path (21.73s)
--- PASS: TestAccIAMVirtualMFADevice_tags (45.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        48.721s

@gdavison gdavison merged commit 5227f6b into main Jul 12, 2023
@gdavison gdavison deleted the b-sweep-mfa-device branch July 12, 2023 21:02
@github-actions github-actions bot added this to the v5.8.0 milestone Jul 12, 2023
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
Update CHANGELOG.md for #32462
d54824d
@github-actions
Copy link

This functionality has been released in v5.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. service/opsworks Issues and PRs that pertain to the opsworks service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b